Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate plugins/profiling-plugin.mdx #386

Merged
merged 6 commits into from
Nov 1, 2021
Merged

Conversation

chopmozzi
Copy link
Contributor

Summary

#384

리뷰 참고 사항

다른 번역에 영문을 그대로 써서 표기한 경우(Chrome, DevTools, webpack)은 그대로 사용하였습니다. profiler의 경우 profile이 프로파일링이라고 번역되긴 하지만 Drag & Drop의 목적지를 표현하기 때문에 영문 그대로 사용하였습니다.

Glossary

custom : 커스텀
Chrome : Chrome
DevTools : DevTools
webpack : webpack
absolute path : 절대 경로
timeline : timeline
profiler : profiler
calls : 호출들
stats : 통계

@chopmozzi chopmozzi requested a review from a team as a code owner October 28, 2021 12:56
@dkstyle dkstyle changed the title Update profiling-plugin.mdx Translate profiling-plugin.mdx Oct 28, 2021
@dkstyle dkstyle changed the title Translate profiling-plugin.mdx Translate plugins/profiling-plugin.mdx Oct 28, 2021
Copy link
Contributor

@dkstyle dkstyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍


It will then display timeline stats and calls per plugin!
위와 같은 과정을 거치면 plugin당 timeline 통계와 호출들이 표시 될 것입니다!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 띄어쓰기 수정
    표시 될 -> 표시될

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정했습니다.

@dkstyle dkstyle self-requested a review November 1, 2021 02:20
@dkstyle dkstyle merged commit af9af83 into line:kr Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants