-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translate plugins/profiling-plugin.mdx #386
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkstyle
changed the title
Translate profiling-plugin.mdx
Translate plugins/profiling-plugin.mdx
Oct 28, 2021
dkstyle
reviewed
Oct 28, 2021
dkstyle
approved these changes
Oct 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
YukJiSoo
reviewed
Oct 30, 2021
YukJiSoo
reviewed
Oct 30, 2021
YukJiSoo
approved these changes
Oct 30, 2021
keipark
approved these changes
Nov 1, 2021
dkstyle
reviewed
Nov 1, 2021
|
||
It will then display timeline stats and calls per plugin! | ||
위와 같은 과정을 거치면 plugin당 timeline 통계와 호출들이 표시 될 것입니다! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 띄어쓰기 수정
표시 될 -> 표시될
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수정했습니다.
choilim
approved these changes
Nov 1, 2021
dkstyle
approved these changes
Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#384
리뷰 참고 사항
다른 번역에 영문을 그대로 써서 표기한 경우(Chrome, DevTools, webpack)은 그대로 사용하였습니다. profiler의 경우 profile이 프로파일링이라고 번역되긴 하지만 Drag & Drop의 목적지를 표현하기 때문에 영문 그대로 사용하였습니다.
Glossary
custom : 커스텀
Chrome : Chrome
DevTools : DevTools
webpack : webpack
absolute path : 절대 경로
timeline : timeline
profiler : profiler
calls : 호출들
stats : 통계