Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text selection: Mouse double click should select a word, and allow highlighting by words #1570

Closed
4 tasks
Ciantic opened this issue Feb 8, 2021 · 4 comments · Fixed by #1666
Closed
4 tasks

Text selection: Mouse double click should select a word, and allow highlighting by words #1570

Ciantic opened this issue Feb 8, 2021 · 4 comments · Fixed by #1666
Labels
enhancement adds or requests a new feature
Milestone
textbox-polish

Comments

@Ciantic
Copy link
Collaborator

Ciantic commented Feb 8, 2021 •
edited
Loading

I tested on TextBox with Windows 10, following didn't work:

  • Mouse double click on word should select a word
  • Mouse double click on a word, and leave mouse button pressed, and then moving mouse selects text by words

Not sure how these are implemented in other OS's but that is a common in Windows 10.

Additionally there is sometimes (Notepad++, Google Chrome):

  • Mouse triple click selects whole paragraph
  • Mouse triple click selects whole paragraph, leave mouse button pressed, moving mouse now selects paragraphs
@cmyr cmyr added the enhancement adds or requests a new feature label Feb 8, 2021
@cmyr
Copy link
Member

cmyr commented Feb 8, 2021

Agree, this is an oversight. I'm not sure how it will interact with IME, but that's something to keep in mind. The behaviours you describe are also standard on macOS.

@cmyr cmyr added this to the textbox-polish milestone Mar 18, 2021
cmyr added a commit that referenced this issue Mar 18, 2021
@cmyr
Drag selection remembers click count
fd34ed6 
This implements the behaviour where the selection behaviour
of a drag gesture varies depending on whether the drag starts
from a single, double, or triple-click.

- closes #1570
@cmyr cmyr mentioned this issue Mar 18, 2021
Merged
cmyr added a commit that referenced this issue Mar 19, 2021
@cmyr
Drag selection remembers click count
70d06e1 
This implements the behaviour where the selection behaviour
of a drag gesture varies depending on whether the drag starts
from a single, double, or triple-click.

- closes #1570
cmyr added a commit that referenced this issue Mar 19, 2021
@cmyr
Drag selection remembers click count
95b75e2 
This implements the behaviour where the selection behaviour
of a drag gesture varies depending on whether the drag starts
from a single, double, or triple-click.

- closes #1570
cmyr added a commit that referenced this issue Mar 30, 2021
@cmyr
Drag selection remembers click count
8cad323 
This implements the behaviour where the selection behaviour
of a drag gesture varies depending on whether the drag starts
from a single, double, or triple-click.

- closes #1570
cmyr added a commit that referenced this issue Mar 30, 2021
@cmyr
Drag selection remembers click count
801e470 
This implements the behaviour where the selection behaviour
of a drag gesture varies depending on whether the drag starts
from a single, double, or triple-click.

- closes #1570
richard-uk1 pushed a commit to richard-uk1/druid that referenced this issue Apr 6, 2021
@cmyr @richard-uk1
Drag selection remembers click count
8d4515e 
This implements the behaviour where the selection behaviour
of a drag gesture varies depending on whether the drag starts
from a single, double, or triple-click.

- closes linebender#1570
@ngugcx
Copy link
Contributor

ngugcx commented Jul 30, 2021

In the flex example of the master branch, a word is still not selected in the text box after double-clicking the mouse.

@cmyr
Copy link
Member

cmyr commented Aug 16, 2021

@ngugcx what platform are you on?

@ngugcx
Copy link
Contributor

ngugcx commented Aug 16, 2021

Windows 10. @cmyr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement adds or requests a new feature
Projects
None yet
Milestone
textbox-polish
Development

Successfully merging a pull request may close this issue.

Drag selection remembers click count linebender/druid
3 participants
@Ciantic @cmyr @ngugcx