Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify example feature requirements in a standard way. #1050

Merged
merged 1 commit into from
Jun 20, 2020

Conversation

xStrom
Copy link
Member

@xStrom xStrom commented Jun 20, 2020

This PR adds the various example feature requirements to Cargo.toml via the required-features field.

This allows the examples themselves to be cleaned up from all the cfg guards, which add needless confusion for new developers.

$ cargo run --example list
error: target `list` in package `druid` requires the features: `im`
Consider enabling them by passing, e.g., `--features="im"`

@xStrom xStrom added examples concerns examples S-needs-review waits for review labels Jun 20, 2020
Copy link
Collaborator

@jneem jneem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better!

@xStrom xStrom removed the S-needs-review waits for review label Jun 20, 2020
@xStrom xStrom merged commit 5348dfe into linebender:master Jun 20, 2020
@xStrom xStrom deleted the example-features branch June 20, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples concerns examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants