Implement request_close() support for Windows in druid-shell #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Thanks for the patch! Can you add it to the changelog also? Look for the line containing #1118 |
|
done! |
|
(updated from master) |
jneem
approved these changes
Sep 17, 2020
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the Windows part of #1159 "Implement close request interception".
This is my first PR for this project; hope my submitting a PR without an introduction or any warning is OK?
I've just encountered the non-working CLOSE_WINDOW while working on an app I'm building as an exercise to grok the Rust way, and fixing it seemed straightforward.
Hope it can be of use.