Fix failure to update dynamic label #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luleyleo
reviewed
Sep 27, 2020
druid/src/widget/label.rs
Outdated
| @@ -477,6 +477,7 @@ impl<T: Data> Widget<T> for Label<T> { | |||
| self.text_should_be_updated = false; | |||
| if data_changed { | |||
| let new_text = self.text.display_text(); | |||
| dbg!(&new_text); | |||
There was a problem hiding this comment.
I don't think this dbg! is intentional?
We were failing to set the text in the update case; this was a consequence of #1252
cmyr
force-pushed
the
fix-broken-label
branch
from
d8c2bf7
to
aeaf7b4
Compare
luleyleo
approved these changes
Sep 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were failing to set the text in the update case; this
was a consequence of #1252