-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiple windows, round two #149
Merged
Merged
Commits on Sep 13, 2019
-
Rollup of @raphlinus's multi-window work
This is a squash of a bunch of wip commits: Starting on multi-window Most flow is in place, but not wired to actual window creation yet. Fix lifetime issues These only show up on Windows (DirectWrite backend). Wire window size propagation Events on window size need to be propagated to the WindowPod so they can be available during layout. There are other ways to do this. Instead of being in WindowPod, maybe the size info should be in WindowState (where prev_paint_time is, for similar reasons), then passed down through LayoutCtxRoot. But this way, at least the RootWidget gets notifications of window size changing, which seems potentially useful. Small progress towards working multi-window Get new window containers working Build the hello example using containers suitable for multi-window. Still WIP, there's no way to create new windows yet. Starting to plumb creation of multiple windows This is basically working but has a few rough spots. One missing feature is an event flow for closing windows, so their state can be cleaned up.
Configuration menu - View commit details
-
Copy full SHA for eb81830 - Browse repository at this point
Copy the full SHA eb81830View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f22a3b - Browse repository at this point
Copy the full SHA 2f22a3bView commit details -
This removes WindowPod and bakes in the simplest case.
Configuration menu - View commit details
-
Copy full SHA for 05c9743 - Browse repository at this point
Copy the full SHA 05c9743View commit details -
[mac] Fix crash when closing window
This might be leaking memory, but that beats a crash in the near-term.
Configuration menu - View commit details
-
Copy full SHA for 82b7dd9 - Browse repository at this point
Copy the full SHA 82b7dd9View commit details -
Configuration menu - View commit details
-
Copy full SHA for c212cbc - Browse repository at this point
Copy the full SHA c212cbcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5388caf - Browse repository at this point
Copy the full SHA 5388cafView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1463276 - Browse repository at this point
Copy the full SHA 1463276View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9caed0e - Browse repository at this point
Copy the full SHA 9caed0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c061b2 - Browse repository at this point
Copy the full SHA 1c061b2View commit details
Commits on Sep 17, 2019
-
- Remove PartialEq for Command/Selector - remove `pub` from Selector.object - rename send_ to do_ in win_handler - cleanup some comments & remove some dead code
Configuration menu - View commit details
-
Copy full SHA for bce4c2f - Browse repository at this point
Copy the full SHA bce4c2fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.