Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple windows, round two #149

Merged
merged 10 commits into from
Sep 17, 2019
Merged

multiple windows, round two #149

merged 10 commits into from
Sep 17, 2019

Commits on Sep 13, 2019

  1. Rollup of @raphlinus's multi-window work

    This is a squash of a bunch of wip commits:
    
    Starting on multi-window
    
    Most flow is in place, but not wired to actual window creation yet.
    
    Fix lifetime issues
    
    These only show up on Windows (DirectWrite backend).
    
    Wire window size propagation
    
    Events on window size need to be propagated to the WindowPod so they
    can be available during layout.
    
    There are other ways to do this. Instead of being in WindowPod, maybe
    the size info should be in WindowState (where prev_paint_time is, for
    similar reasons), then passed down through LayoutCtxRoot.
    
    But this way, at least the RootWidget gets notifications of window size
    changing, which seems potentially useful.
    
    Small progress towards working multi-window
    
    Get new window containers working
    
    Build the hello example using containers suitable for multi-window.
    
    Still WIP, there's no way to create new windows yet.
    
    Starting to plumb creation of multiple windows
    
    This is basically working but has a few rough spots. One missing feature
    is an event flow for closing windows, so their state can be cleaned up.
    raphlinus authored and cmyr committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    eb81830 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2f22a3b View commit details
    Browse the repository at this point in the history
  3. Simplify multi-win

    This removes WindowPod and bakes in the simplest case.
    cmyr committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    05c9743 View commit details
    Browse the repository at this point in the history
  4. [mac] Fix crash when closing window

    This might be leaking memory, but that beats a crash in the near-term.
    cmyr committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    82b7dd9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c212cbc View commit details
    Browse the repository at this point in the history
  6. Update all windows after event

    cmyr committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    5388caf View commit details
    Browse the repository at this point in the history
  7. Docs and cleanup

    cmyr committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    1463276 View commit details
    Browse the repository at this point in the history
  8. Remove UiState & UiMain

    cmyr committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    9caed0e View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    1c061b2 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2019

  1. Review feedback

    - Remove PartialEq for Command/Selector
    - remove `pub` from Selector.object
    - rename send_ to do_ in win_handler
    - cleanup some comments & remove some dead code
    cmyr committed Sep 17, 2019
    Configuration menu
    Copy the full SHA
    bce4c2f View commit details
    Browse the repository at this point in the history