Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ViewSwitcher doc to be more accurate #1693

Merged
merged 5 commits into from
Apr 7, 2021
Merged

Update ViewSwitcher doc to be more accurate #1693

merged 5 commits into from
Apr 7, 2021

Conversation

arthmis
Copy link
Collaborator

@arthmis arthmis commented Apr 3, 2021 •
edited
Loading

I don't know why the previous doc comment was added, but it was inaccurate. It made people have the wrong impression of what ViewSwitcher was capable of.

cmyr
cmyr approved these changes Apr 4, 2021
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the widget docs were definitely wrong.

druid/src/widget/view_switcher.rs Outdated Show resolved Hide resolved
@SecondFlight
Copy link
Collaborator

@arthmis I noticed you don't have a changelog entry for this PR (or for #1691). Would you like to update the changelog before these are merged?

@SecondFlight SecondFlight added the S-waiting-on-author waits for changes from the submitter label Apr 5, 2021
@arthmis
Copy link
Collaborator Author

arthmis commented Apr 5, 2021

Yes, I keep forgetting.

@SecondFlight SecondFlight removed the S-waiting-on-author waits for changes from the submitter label Apr 5, 2021
@SecondFlight SecondFlight changed the title updating viewswitcher doc to be more accurate Update ViewSwitcher doc to be more accurate Apr 7, 2021
@SecondFlight SecondFlight merged commit 34e864d into linebender:master Apr 7, 2021
@arthmis arthmis deleted the view-switcher-docs branch April 7, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SecondFlight SecondFlight SecondFlight approved these changes

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arthmis @SecondFlight @cmyr