Focus-chain update #1724
Merged
Focus-chain update #1724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Local fork
…o hidden widgets anymore. Signed-off-by: xarvic <xarvix@web.de>
Signed-off-by: xarvic <xarvix@web.de>
Signed-off-by: xarvic <xarvix@web.de>
Signed-off-by: xarvic <xarvix@web.de>
cmyr
reviewed
Apr 18, 2021
| // currently focused is not part of the functional tree anymore | ||
| // (Lifecycle::BuildFocusChain.should_propagate_to_hidden() is false!) and should | ||
| // resign the focus. | ||
| if had_focus && !self.state.has_focus { |
There was a problem hiding this comment.
I'm confused; we haven't done merge_up yet, so how would has_focus have changed?
There was a problem hiding this comment.
The merge_up of our children happened already in line 1058 / 1062. If someone hides a focused widget and then calls children_changed(), we clear has_focus in BuildFocusChain if has_clear is not set after the calls in 1058 and 1062 we know, that the focused widget is not reachable
Co-authored-by: Colin Rofls <colin@cmyr.net>
cmyr
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix of the part of #1716 @cmyr and i agreed on:
should_propagate_to_hidden()now returnsfalseforLifecycle::BuildFocusChainLifecycle::BuildFocusChainrequests a a resign of focus ifstate.has_focusis set but neither one of its hidden children nor it self has focus.The other point: What should happen if try to focus a WidgetID which is not allowed to recieve focus like
ctx.set_focus(WidgetID::new())or focusing a hidden widget is not addressed here.