Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added font support for SVG text #1850

Merged
merged 4 commits into from
Jul 14, 2021
Merged

Conversation

DrGabble
Copy link
Contributor

@DrGabble DrGabble commented Jul 3, 2021

Fixes #1827

Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable. It would be nice if we could somehow defer font loading until we knew that fonts were needed, since it likely has some cost, but I'm fine with worrying about that later if it seems like a problem. :)

@@ -12,6 +12,7 @@ You can find its changes [documented below](#070---2021-01-01).

### Added

- System fonts loaded so that SVG images render text ([#1850] by [@DrGabble])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll also need to add the link to the PR below. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DrGabble this is ready to merge except for this missing link!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmyr done!

@cmyr cmyr added the S-waiting-on-author waits for changes from the submitter label Jul 5, 2021
@DrGabble
Copy link
Contributor Author

DrGabble commented Jul 6, 2021

This seems reasonable. It would be nice if we could somehow defer font loading until we knew that fonts were needed, since it likely has some cost, but I'm fine with worrying about that later if it seems like a problem. :)

Yeah doing that automatically is probably hard. Could add a function for "new_with_text" but seems like people might miss it. Agreed it will make things more expensive but we can fix that later if it becomes an issue :)

@DrGabble
Copy link
Contributor Author

DrGabble commented Jul 7, 2021 via email

@cmyr cmyr merged commit bb04818 into linebender:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author waits for changes from the submitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svg Widget doesn't render fonts
2 participants