-
Notifications
You must be signed in to change notification settings - Fork 568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added font support for SVG text #1850
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable. It would be nice if we could somehow defer font loading until we knew that fonts were needed, since it likely has some cost, but I'm fine with worrying about that later if it seems like a problem. :)
@@ -12,6 +12,7 @@ You can find its changes [documented below](#070---2021-01-01). | |||
|
|||
### Added | |||
|
|||
- System fonts loaded so that SVG images render text ([#1850] by [@DrGabble]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you'll also need to add the link to the PR below. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DrGabble this is ready to merge except for this missing link!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmyr done!
Yeah doing that automatically is probably hard. Could add a function for "new_with_text" but seems like people might miss it. Agreed it will make things more expensive but we can fix that later if it becomes an issue :) |
Yes sorry, VM packed in, it's on my to-do list don't worry
Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: Colin Rofls ***@***.***>
Sent: Wednesday, July 7, 2021 4:07:28 PM
To: linebender/druid ***@***.***>
Cc: DrGabble ***@***.***>; Mention ***@***.***>
Subject: Re: [linebender/druid] Added font support for SVG text (#1850)
@cmyr commented on this pull request.
________________________________
In CHANGELOG.md<#1850 (comment)>:
@@ -12,6 +12,7 @@ You can find its changes [documented below](#70---2021-01-01).
### Added
+- System fonts loaded so that SVG images render text ([#1850] by [@DrGabble])
@DrGabble<https://github.com/DrGabble> this is ready to merge except for this missing link!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1850 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADTUJ2KEVRMQYA7D2WIBO63TWRUTBANCNFSM47YRTUKQ>.
|
Fixes #1827