Change request_timer to work with Duration #847
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the wasm PR I've been thinking about changing
request_timer
to takeDuration
instead ofInstant
, considering that I've never seen it being called in a different way thanWith this it's just
That would allow us to get rid of Instant as part of our API and thus
instant::Instant
would not be necessary in user code when targeting wasm.This should also fix the wasm CI