Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change request_timer to work with Duration #847

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

luleyleo
Copy link
Collaborator

@luleyleo luleyleo commented Apr 15, 2020

Since the wasm PR I've been thinking about changing request_timer to take Duration instead of Instant, considering that I've never seen it being called in a different way than

ctx.request_timer(Instant::now() + some_duration)

With this it's just

ctx.request_timer(some_duration)

That would allow us to get rid of Instant as part of our API and thus instant::Instant would not be necessary in user code when targeting wasm.

This should also fix the wasm CI

@luleyleo
Copy link
Collaborator Author

Looks like it does indeed fix the pipeline 😄

@luleyleo luleyleo requested a review from cmyr April 15, 2020 19:33
@luleyleo luleyleo added the breaking change pull request breaks user code label Apr 15, 2020
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea to me. Also I want to get the CI fixed sooner than later.

@xStrom xStrom merged commit 0c6ff87 into linebender:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change pull request breaks user code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants