Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UpdateCtx::request_timer and request_anim_frame. #898

Merged
merged 3 commits into from
May 3, 2020
Merged

Add UpdateCtx::request_timer and request_anim_frame. #898

merged 3 commits into from
May 3, 2020

Conversation

luleyleo
Copy link
Collaborator

@luleyleo luleyleo commented May 2, 2020

This adds UpdateCtx::request_timer and request_anim_frame.
Also the Switch widget animates external changes of its state, the switch example now has a checkbox next to the Switch to test this.

@luleyleo luleyleo marked this pull request as ready for review May 2, 2020 16:57
@luleyleo luleyleo added the S-needs-review waits for review label May 2, 2020
zaynetro
zaynetro reviewed May 2, 2020
View reviewed changes
druid/src/widget/switch.rs Outdated Show resolved Hide resolved
xStrom
xStrom approved these changes May 3, 2020
View reviewed changes
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@luleyleo luleyleo merged commit 3846a83 into linebender:master May 3, 2020
@xStrom xStrom removed the S-needs-review waits for review label May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaynetro zaynetro zaynetro left review comments

@xStrom xStrom xStrom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luleyleo @zaynetro @xStrom