Update screenshots in the readme. #967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luleyleo
reviewed
May 21, 2020
There was a problem hiding this comment.
Those look great, thanks!
And I've managed to find out where the URLs come from:
https://github.com/xi-editor/druid/tree/screenshots
https://raw.githubusercontent.com/xi-editor/druid/screenshots/images/hello.png
= https://raw.githubusercontent.com/xi-editor/druid/{branch}/images/hello.png
I suppose the new screenshots should go there too?
|
Great find! I posted #968 which adds the screenshot files to that branch and updated this PR here to use those URLs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshots I made:
calcon Windows 10 / macOS Catalina / Ubuntu 20.04 / Firefox (Win10)flexon Windows 7 with debug borders enabledcustom_widgeton Windows 7The
calcscreenshots are one big image so that they line up, while still keeping the image width below 600px so it shows up nicely on crates.io.PS. The previous screenshots were uploaded to URLs like
https://raw.githubusercontent.com/xi-editor/druid/screenshots/images/calc.png. I don't know how to do that, so mine are issue uploads likehttps://user-images.githubusercontent.com/754881/82576269-5281f300-9b92-11ea-887b-1f61f1a2a8b0.png.