Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename WidgetPod::paint_with_offset to just paint #980

Merged
merged 2 commits into from
May 25, 2020
Merged

Rename WidgetPod::paint_with_offset to just paint #980

merged 2 commits into from
May 25, 2020

Conversation

totsteps
Copy link
Collaborator

closes #962

@totsteps totsteps added breaking change pull request breaks user code S-needs-review waits for review labels May 22, 2020
@jneem
Copy link
Collaborator

jneem commented May 23, 2020

Just came by to check if you remembered to change all the paint()s to paint_raw()s. 👍

xStrom
xStrom reviewed May 23, 2020
View reviewed changes
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just a few adjustments.

druid/src/core.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@xStrom xStrom added S-waiting-on-author waits for changes from the submitter and removed S-needs-review waits for review labels May 23, 2020
@totsteps totsteps added S-needs-review waits for review and removed S-waiting-on-author waits for changes from the submitter labels May 23, 2020
xStrom
xStrom approved these changes May 23, 2020
View reviewed changes
Copy link
Member

@xStrom xStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@xStrom xStrom removed the S-needs-review waits for review label May 23, 2020
@xStrom xStrom merged commit 284daf3 into linebender:master May 25, 2020
@totsteps totsteps deleted the rename-paint_with_offset branch May 25, 2020 14:31
@mmitteregger mmitteregger mentioned this pull request Jun 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xStrom xStrom xStrom approved these changes

Assignees
No one assigned
Labels
breaking change pull request breaks user code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename WidgetPod::paint_with_offset to just 'paint'
3 participants
@totsteps @jneem @xStrom