Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factored out file loading on render tick for winit bin #162

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Factored out file loading on render tick for winit bin #162

merged 1 commit into from
Apr 5, 2022

Conversation

simbleau
Copy link
Member

@simbleau simbleau commented Apr 4, 2022

Closes #161

@simbleau
Copy link
Member Author

simbleau commented Apr 4, 2022 •
edited
Loading

Just wanted to leave a note that I had to change visibility of PicoSvg to pub at the crate level for this refactor.

@simbleau simbleau mentioned this pull request Apr 4, 2022
Closed
raphlinus
raphlinus approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@raphlinus raphlinus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this should help with benchmarking.

@raphlinus raphlinus merged commit 38b44b1 into linebender:master Apr 5, 2022
@simbleau simbleau deleted the issue-161 branch April 5, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphlinus raphlinus raphlinus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate reparsing in SVG Rendering native example
2 participants
@simbleau @raphlinus