Remove piet API and replace with scene fragments #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the dependency on the piet crate and replaces all uses with the scene crate. Also does some cleanup of the scene API, renaming some types and moving them all to the crate root for better ergonomics.
Removes ResourceContext type. This makes scenes and fragments nearly identical. Should they be merged?
Removes the transform state mutator from SceneBuilder and adds transform parameters to push_layer, fill and stroke methods.
* Fix call to removed encoded_scene method in pgpu-render * Add new ImageFormat::Surface variant to select a pixel format that matches the platform specific surface format. This makes gradients consistent across platforms.
Update various dependencies to latest.
Follow API changes introduced by ash, ash_window, and raw_window_handle. Also updates ash_window to 0.12. Note: this doesn't fix the android client.
Updates the android example to use latest ash plumbing.
Co-authored-by: m-hugo <56653363+m-hugo@users.noreply.github.com>
Update dependencies
raphlinus
approved these changes
Oct 19, 2022
Removes the dependency on the piet crate and replaces all uses with the scene crate. Also does some cleanup of the scene API, renaming some types and moving them all to the crate root for better ergonomics.
Removes ResourceContext type. This makes scenes and fragments nearly identical. Should they be merged?
Removes the transform state mutator from SceneBuilder and adds transform parameters to push_layer, fill and stroke methods.
* Fix call to removed encoded_scene method in pgpu-render * Add new ImageFormat::Surface variant to select a pixel format that matches the platform specific surface format. This makes gradients consistent across platforms.
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency on the piet crate and replaces it with piet-scene. It also includes some renaming of types and reorganization of the scene crate to provide a more ergonomic API. Some more work is probably necessary here, certainly with regard to documentation.
The swash dependency is also removed and very simple text support has been added (based on piet-scene/moscato) to support rendering info strings.
Finally, gradient ramp caching is moved back to piet-gpu and handled during scene upload. This has the side effect of making the Scene and SceneFragment types nearly identical. It's worth discussing whether it makes sense to retain the distinct types.