CI and local smoke testing #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJMcNab
force-pushed
the
initial-tests
branch
from
1f7d334
to
a73e6d6
Compare
Co-Authored-By: Chad Brokaw <cbrokaw@gmail.com>
DJMcNab
force-pushed
the
initial-tests
branch
from
9abcceb
to
99ea136
Compare
DJMcNab
changed the title
DJMcNab
changed the title
waywardmonkeys
approved these changes
Feb 15, 2024
simbleau
pushed a commit
that referenced
this pull request
Feb 20, 2024
* Use `next_multiple_of` * Sketch out how tests can work * Fix clippy failure * build script: rerun properly * See if lavapipe will get vello working * Fix the CPU shaders Co-Authored-By: Chad Brokaw <cbrokaw@gmail.com> * Make the GPU support conditional * Make include be strings properly * Try changing the variable name to not have an underscore * Add a standard debugging environment variable * Disable the GPU tests on macOS * Rename the "concave" tests to "smoke" tests * Fix clippy issues and make env var match (PR) docs --------- Co-authored-by: Chad Brokaw <cbrokaw@gmail.com>
This was referenced Apr 29, 2024
github-merge-queue bot
pushed a commit
to linebender/xilem
that referenced
this pull request
Aug 5, 2024
See also linebender/vello#439 This should open the door to doing much more comprehensive testing at higher level in the nearish future (including e.g. in `xilem_masonry`)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To run the tests locally, use:
These are placed in a new (non-publishing)
vello_testscrate. The lib.rs of this crate has helpers for creating test cases, adapted from the headless example.There is currently one additional set of tests, the
smoke.rstests. This has one test with two instantiations (over the value ofuse_cpu). This test issimple_square, which draws a 50px by 50px square, and confirms that 2500 pixels are red (and that the remainder are black).There is a debug environment variable, which is
VELLO_DEBUG_TESTS. This controls the debug output to PNG of these tests. These png are output into thedebug_outputsfolder. The environment variable takes a list of tests to debug, separated by commas. E.g.VELLO_DEBUG_TESTS=simple_square_cpuwould debug the testsimple_squarewithuse_cpuenabled. Thecpu/gpusuffices are optional, e.g.VELLO_DEBUG_TESTS=simple_squarewould output the png for bothsimple_square_cpuandsimple_square_gpu.There are also three special values:
all, which debugs every testcpu, which debugs the CPU version of every testgpu, which debugs the GPU version of every testIn terms of CI, this uses Mesa (and thus lavapipe?) to run the shaders on the CPU of the runner. This is only possible on Ubuntu. In theory, windows has a fallback CPU implementation of DirectX, but I haven't dug into this yet