Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tasks are not overridable #23

Closed
davemo opened this issue Oct 29, 2012 · 0 comments
Closed

Tasks are not overridable #23

davemo opened this issue Oct 29, 2012 · 0 comments
Labels

Comments

@davemo
Copy link
Member

davemo commented Oct 29, 2012

node_modules/lineman/config/application.js defines the root tasks that lineman executes in each of its configurations common, watch, dist.

Other properties of this file are overridable in {project}/config/application.js but not the actual list of tasks due to the way tasks are fetched inside lineman/cli.js ...

    appTasks = require(__dirname + '/config/application.js').appTasks,

We need to modify this so the list of tasks is overridable or exclude them from node_modules/lineman/config/application.js so as not to confuse people. Files in the config folder in the generated project should only point to lineman/config files that contain overridable keys.

As a general note, we should probably be clearer about what we intend to be overridable. (All? None? Some with clearer docs?).

@davemo davemo mentioned this issue Oct 31, 2012
nagyv added a commit to pulilab/lineman that referenced this issue Oct 31, 2012
nagyv added a commit to pulilab/lineman that referenced this issue Oct 31, 2012
@davemo davemo closed this as completed in 2cc43d5 Oct 31, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant