-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release workflow #58
Conversation
1803c4c
to
fea7a13
Compare
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
=======================================
Coverage 68.59% 68.59%
=======================================
Files 22 22
Lines 4053 4053
Branches 1028 1028
=======================================
Hits 2780 2780
Misses 1130 1130
Partials 143 143 Continue to review full report at Codecov.
|
Can we open an issue for this to discuss the principles we're aiming for. Is it related to #60 ? |
Even if we decide to do a rewrite, having a working CI/CD pipeline is going to be a requirement. So getting this up in working order and merged would benefit a greenfield codebase just as much as the current one. |
@goofballLogic, in #60 (comment) you asked:
Indeed it is. I haven't spent much time trying to figure this one out, but currently the build is failing at the
If anyone can assist in figuring out why |
done #64 |
This issue has been automatically marked as stale because it has not had recent activity. After 30 days from now, it will be closed if no further activity occurs. Thank you for your contributions. |
Revert the job-splitting as uploading and downloading the build artifacts take several minutes to complete.
dotnet pack defaults to Debug but we build Release
3e65554
to
d8bf25b
Compare
e6797aa
to
b83a06d
Compare
641dcaa
to
32ef660
Compare
- Add NuGet push to production job `nuget-push-prod`. - Add NuGet push to development job `nuget-push-dev`. - Add job `release-artifacts` to upload `.nuget` to the GitHub Release corresponding to the current tag (if any).
32ef660
to
cb0fb90
Compare
This won't be tested properly until it's merged to |
Happy to merge on that basis. |
This adds a release workflow that will add to the existing test workflow, which in total should make the CI/CD pipeline look like this:
master
.master
will invoke the release pipeline to release a pre-release package to the GitHub Package Registry.master
a maintainer creates a new GitHub Release versioned according to SemVer 2.0.Thoughts, comments and general feedback is welcome.