Upgrade sarama dependency to support Kafka 0.11.0 #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpocius
changed the title
2 similar comments
1 similar comment
2 similar comments
toddpalino
requested changes
Dec 4, 2017
Gopkg.lock
Outdated
| revision = "bbdbe644099b7fdc8327d5cc69c030945188b2e9" | ||
| version = "v1.13.0" | ||
| revision = "240fd146ce68bcafb034cc5dc977229ffbafa8ea" | ||
| version = "v1.14.0" |
There was a problem hiding this comment.
You should not be editing the Gopkg.lock file. Changes like this have to go into the Gopkg.toml file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Burrow 0.1.1 was working just fine with Kafka 0.11.0.1, but due to the introduction of a new helper in the latest version, it now fails to start with the following error:
Now I could probably work around it by simply specifying a lower version of Kafka than I'm actually using, but we might as well do it properly, right?
I checked sarama changes and it doesn't look like it would break anything in Burrow.