Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse http notifier open-url and close-url as templates. #390

Merged
merged 2 commits into from
Aug 14, 2019

Conversation

vixns
Copy link
Contributor

@vixns vixns commented May 3, 2018

see #355

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 73.938% when pulling 8d3ec19 on vixns:templated_url2 into fecab1e on linkedin:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.08%) to 73.938% when pulling 8d3ec19 on vixns:templated_url2 into fecab1e on linkedin:master.

@cdenneen
Copy link

@vixns What's the status for getting this passing?
Do you have example opsgenie template you are using?
@toddpalino

@vixns
Copy link
Contributor Author

vixns commented Jun 25, 2019

@cdenneen

[notifier.default]
class-name="http"
url-open="https://api.opsgenie.com/v2/alerts"
url-close="https://api.opsgenie.com/v2/alerts/{{.ID}}/close?identifierType=alias"
method-open="POST"
template-open="_HIDDEN_/opsgenie-create.tmpl"
template-close="_HIDDEN_/opsgenie-delete.tmpl"
interval=60
timeout=5
keepalive=30
headers={ Authorization="GenieKey _HIDDEN_" }
method-close="POST"
send-close=true
threshold=2

@cdenneen
Copy link

cdenneen commented Jun 25, 2019

@vixns thanks, so is the PR still necessary?...
@toddpalino can this get merged or do you need additional tests?

@cdenneen
Copy link

@bai anyway to get this merged?

@bai
Copy link
Collaborator

bai commented Aug 14, 2019

Thanks 👍

@bai bai merged commit e685792 into linkedin:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants