Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add blacklist for memory store #404

Merged
merged 9 commits into from
Nov 30, 2018
Merged

Conversation

cvaliente
Copy link
Contributor

the consumer configuration allows defining both a blacklist and a whitelist while the memory storage only has a whitelist. This makes it more consistent, allowing both consumers and storage to be configured with the same filter.

@coveralls
Copy link

coveralls commented May 30, 2018

Coverage Status

Coverage increased (+0.04%) to 74.066% when pulling 74b309f on cvaliente:storageblacklist into fecab1e on linkedin:master.

@sam-obeid
Copy link

This is useful! +1

@vvuibert
Copy link
Contributor

vvuibert commented Oct 11, 2018

I tested this branch and it does not work me. Adding a group-whitelist in the storage section of the config file works, but adding group-blacklist has no effect.
The group-blacklist would be really useful though
(edit) this does work 👍

@bai
Copy link
Collaborator

bai commented Oct 11, 2018

Could we use negative regex in whitelist to achieve similar functionality?

@vvuibert
Copy link
Contributor

@bai I believe that go doesn't allow negative regex and that is why we have a black list for the notifier and the consumer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants