Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow underscore in hostname #545

Merged
merged 6 commits into from
Jan 31, 2020
Merged

Allow underscore in hostname #545

merged 6 commits into from
Jan 31, 2020

Conversation

Lukkie
Copy link
Contributor

@Lukkie Lukkie commented Jul 1, 2019

We're working with multiple zookeeper and kafka stacks in the same Docker Swarm network. In the configuration, we would like to distinguish between services of these stacks by calling them with their full Docker Swarm service name, which looks like [stack-name]_[service-name], so we would for instance have stack1_zookeeper:2181 and stack2_zookeeper:2181 which belong to different stacks.

We tried following config:

[zookeeper]
servers=[ "cluster1_zookeeper1:2181", "cluster1_zookeeper2:2181", "cluster1_zookeeper3:2181" ]
timeout=6

but received following error:
{"level":"panic","ts":1561966576.124533,"msg":"Failed to validate Zookeeper servers"}

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 74.736% when pulling 3e5e06d on Lukkie:master into a449cc4 on linkedin:master.

@Lukkie
Copy link
Contributor Author

Lukkie commented Sep 3, 2019

Anyone?

@bai
Copy link
Collaborator

bai commented Jan 31, 2020

Thanks for contributing 🙏

@bai bai merged commit 0613668 into linkedin:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants