Expose network timeout consumer configs via client profile #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows users to set initial connection & RPC response read timeouts for kafka client. The underlying sarama lib has these two documented as, ``` DialTimeout time.Duration // How long to wait for the initial connection. ReadTimeout time.Duration // How long to wait for a response. ``` Through these configs, one could deal with slow responding brokers and avoid i/o timeouts. The change also includes minor refactoring to keep the linter happy, s/time/timestamp to avoid overshadowing from the new 'time' import
|
I understand this need to be accompanied with a change in the documentation to include these configs. Please let me know the process for that. |
|
Thanks for contributing! <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows users to set initial connection & RPC response read timeouts
for kafka client. The underlying sarama lib has these two documented as,
Through these configs, one could deal with slow responding brokers and avoid
i/o timeouts.
The change also includes minor refactoring to keep the linter happy,
s/time/timestamp to avoid overshadowing from the new 'time' import