Fix the bug that retentionTimeInSeconds can be null #2421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingQianCloud
approved these changes
Mar 30, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2421 +/- ##
============================================
- Coverage 73.38% 68.65% -4.73%
+ Complexity 10846 10196 -650
============================================
Files 773 773
Lines 60721 60721
Branches 7440 7440
============================================
- Hits 44558 41688 -2870
- Misses 13717 16647 +2930
+ Partials 2446 2386 -60 see 157 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
MikeDafi
pushed a commit
to MikeDafi/ambry
that referenced
this pull request
Jun 20, 2023
Co-authored-by: Sophie Guo <sopguo@sopguo-mn1.linkedin.biz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.