Propagate I/O errors from filesystem and serialization failures #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhamiltoncx
force-pushed
the
propagate-errors
branch
3 times, most recently
from
d7ebdf4
to
5c2e4b7
Compare
nikhilbedi
requested changes
Jul 14, 2021
bhamiltoncx
force-pushed
the
propagate-errors
branch
from
5c2e4b7
to
61605f7
Compare
Thanks again! I think I fixed the issue, but I didn't quite understand this part:
Let me know if the updated PR does what you were looking for — I wasn't 100% sure what you meant there. |
|
Forgot to update |
nikhilbedi
requested changes
Jul 16, 2021
Previously, I/O and serialization/deserialization errors were silently swallowed. This commit makes use of the NSFileHandle APIs on iOS 13 and later to perform filesystem operations and propagate the errors to the caller. The following APIs are now deprecated in favor of the variants that take a (nullable) `NSError **`: ``` -[CASQueueFile add:] -[CASQueueFile peek:] -[CASQueueFile pop:] -[CASQueueFile clear] -[CASObjectQueue add:] -[CASObjectQueue peek:] -[CASObjectQueue pop:] -[CASObjectQueue clear] ``` In addition, the two convenience methods `-peek` and `-pop` to access a single element are deprecated since there is no way to distinguish an empty queue from an error: ``` -[CASObjectQueue peek] -[CASObjectQueue pop] ``` Use `-peek:error:` and `-pop:error:` instead, and call `-firstObject` on the result if you don't need to distinguish an empty queue from an error.
…pport new NSFileHandle APIs
bhamiltoncx
force-pushed
the
propagate-errors
branch
from
4e302ac
to
b17708b
Compare
nikhilbedi
approved these changes
Jul 17, 2021
|
Thanks for doing this! Adding proper error handling has been a long-standing TODO :) |
|
Glad to help! I have a few more little features coming for you. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #7 .
Previously, I/O and serialization/deserialization errors were silently
swallowed.
This commit makes use of the NSFileHandle APIs on iOS 13 and later to
perform filesystem operations and propagate the errors to the caller.
The following APIs are now deprecated in favor of the variants that take
a (nullable)
NSError **:In addition, the two convenience methods
-peekand-popto accessa single element are deprecated since there is no way to distinguish
an empty queue from an error:
Use
-peek:error:and-pop:error:instead, and call-firstObjecton the result if you don't need to distinguish an empty queue from an
error.
I also bumped the Azure Xcode version to Xcode 12 so CI builds with the new APIs.