-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Shade trino-parser dependency of coral-trino #205 #220
Conversation
ab9b4c8
to
5deb4df
Compare
@@ -5,7 +5,8 @@ def modules = [ | |||
'coral-spark', | |||
'coral-schema', | |||
'coral-spark-plan', | |||
'coral-trino' | |||
'coral-trino', | |||
'shading' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we be more specific on what it shades, or are we foresee other shading components ?
@@ -0,0 +1,22 @@ | |||
import com.github.jengelman.gradle.plugins.shadow.tasks.ConfigureShadowRelocation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if it's a good idea to make the shaded librarie as a separate module, and let the previous module depend on it (rather than just shade within the previous module directly)
But if we go this route, we need to also publish this shaded module (ref: https://imperceptiblethoughts.com/shadow/publishing/#publishing-with-maven-publish-plugin) , so that the downstream can continue to consume coral as a library.
5deb4df
to
274a425
Compare
274a425
to
96a8210
Compare
This caused release failures due to the following error:
We should not publish the |
shading trino-parser dependeny [https://github.com//issues/205]