Rebrand HiveConvertletTable to CoralConvertletTable #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljfgem
reviewed
Jul 24, 2024
| * @see ReflectiveConvertletTable documentation for method naming and visibility rules | ||
| */ | ||
| public class HiveConvertletTable extends ReflectiveConvertletTable { | ||
| public class CoralConvertletTable extends ReflectiveConvertletTable { |
There was a problem hiding this comment.
I think we can move it to coral-common?
There was a problem hiding this comment.
There's a few newly "Coral IR specific" classes still in coral-hive such as CoralINOperator and CoralRelToSqlNodeConverter. The plan is to refactor these correctly in one future PR.
ljfgem
approved these changes
Jul 24, 2024
KevinGe00
added a commit
to KevinGe00/coral
that referenced
this pull request
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request, and why are they necessary?
As part of Coral IR improvement work, we want to remove any language specific transformations in the RelNode layer. This PR replaces
HiveConvertletTabletoCoralConvertletTable, as we still need RelNode layer transformations to happen inCoralConvertletTablethat only specific to keeping Coral IR consistent through CoralSqlNode1 -> CoralRelNode -> CoralSqlNode2.How was this patch tested?
clean build