Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up #27

Merged
merged 1 commit into from
Aug 31, 2017
Merged

clean up #27

merged 1 commit into from
Aug 31, 2017

Conversation

brennv
Copy link
Contributor

@brennv brennv commented Aug 28, 2017

No description provided.

@brennv brennv mentioned this pull request Aug 28, 2017
8 tasks
@RiteshMaheshwari
Copy link
Contributor

@brennv Can you describe why this change is needed? Is this a must have or nice to have?

@brennv
Copy link
Contributor Author

brennv commented Aug 29, 2017

As it is now the purpose of this PR is to fix spacing. The rest of the spacing changes were applied in #21 but tests/ was left out because of merge conflicts.

The follow-on Python 3 work was done in 4-spaced. So 703ec98 above is also needed for af4de3c in #28.

Also created issue #22 to discuss the wider approach

@RiteshMaheshwari RiteshMaheshwari merged commit bed35fa into linkedin:master Aug 31, 2017
@brennv brennv mentioned this pull request Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants