Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better typing for spaniel observer payload #158

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

asakusuma
Copy link
Contributor

Previously, the spaniel observer entry payload was typed with "any." This is obviously bad, and I've updated the code to use a generic instead, so the payload is typed. Also, we were defining label as optional in the spaniel observer entry, when it is guaranteed to exist since we have always required the label in the threshold that users provide.

Previously, the spaniel observer entry payload was typed with "any." This is obviously bad, and I've updated the code to use a generic instead, so the payload is typed. Also, we were defining label as optional in the spaniel observer entry, when it is guaranteed to exist since we have always required the label in the threshold that users provide.
@asakusuma asakusuma merged commit 845d8b7 into linkedin:v2-release Aug 18, 2021
asakusuma added a commit to asakusuma/spaniel-1 that referenced this pull request Aug 20, 2021
Missed these payload typings in linkedin#158
asakusuma added a commit that referenced this pull request Aug 20, 2021
Missed these payload typings in #158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant