Add restore command to ZK CLI #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narendly
reviewed
Mar 22, 2021
zookeeper-server/src/main/java/org/apache/zookeeper/server/backup/BackupConfig.java
Outdated
Show resolved
Hide resolved
junkaixue
reviewed
Mar 23, 2021
zookeeper-server/src/main/java/org/apache/zookeeper/server/backup/RestoreFromBackupTool.java
Outdated
Show resolved
Hide resolved
zookeeper-server/src/main/java/org/apache/zookeeper/server/backup/RestoreFromBackupTool.java
Outdated
Show resolved
Hide resolved
mgao0
changed the title
narendly
reviewed
Mar 26, 2021
zookeeper-server/src/main/java/org/apache/zookeeper/server/backup/BackupConfig.java
Outdated
Show resolved
Hide resolved
narendly
reviewed
Mar 26, 2021
zookeeper-server/src/main/java/org/apache/zookeeper/server/backup/RestoreFromBackupTool.java
Show resolved
Hide resolved
narendly
reviewed
Mar 26, 2021
zookeeper-server/src/main/java/org/apache/zookeeper/cli/RestoreCommand.java
Outdated
Show resolved
Hide resolved
narendly
reviewed
Mar 26, 2021
zookeeper-server/src/test/java/org/apache/zookeeper/server/backup/RestorationToolTest.java
Outdated
Show resolved
Hide resolved
narendly
reviewed
Mar 29, 2021
zookeeper-server/src/main/java/org/apache/zookeeper/server/backup/BackupConfig.java
Outdated
Show resolved
Hide resolved
narendly
reviewed
Mar 29, 2021
zookeeper-server/src/main/java/org/apache/zookeeper/cli/RestoreCommand.java
Outdated
Show resolved
Hide resolved
narendly
approved these changes
Mar 29, 2021
narendly
pushed a commit
that referenced
this pull request
Nov 23, 2021
This commit adds a CLI command to ZooKeeperMain, and it will allow zk admin to run commands on a machine to restore the backed-up zk snapshot and transaction log files up until a specified zxid or timestamp from backup storage to a local path. This enables the offline restoration of a zk server node to a desired time/zxid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a CLI command to ZooKeeperMain, and it will allow zk admin to run commands on a machine to restore the backed-up zk snapshot and transaction log files up until a specified zxid or timestamp from backup storage to a local path. This enables the offline restoration of a zk server node to a desired time/zxid.
Tests added: testRestoreToZxidByCommandLine, testRestoreToTimestampByCommandLine
RestorationToolTest: 6 total, 6 passed
RestorationToolTest.testFailedRestorationWithOutOfRangeZxid passed 7.85s
RestorationToolTest.testSuccessfulRestorationToZxid passed 7.21s
RestorationToolTest.testRestoreToZxidByCommandLine passed 6.12s
RestorationToolTest.testRestoreToTimestampByCommandLine passed 7.45s
RestorationToolTest.testSuccessfulRestorationToLatest passed 5.92s
RestorationToolTest.testFailedRestorationWithLostLog passed 5.94s