Ingress: clean nginx, traefik and ambassador tests #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ihcsim
approved these changes
Aug 11, 2020
specs/ingress/tests.go
Outdated
|
|
||
| var cmd *exec.Cmd | ||
| if tc.ingressName != "ambassador" { | ||
| cmd, err = beginPortForward(tc.namespace, "deploy/"+tc.controllerDeployName) |
There was a problem hiding this comment.
Any reasons why we don't want to use the svc of the controller here? E.g., nginx-ingress has the ingress-nginx-controller service, and traefik has traefik-ingress-controller.
specs/ingress/tests.go
Outdated
| "github.com/onsi/gomega" | ||
| ) | ||
|
|
||
| func pingEmojivoto(ip string) error { | ||
| req, err := http.NewRequest("GET", fmt.Sprintf("http://%s", ip), nil) | ||
| func pingIngress() error { |
There was a problem hiding this comment.
NIt: Consider renaming this function, because in the context of network tests, ping means ICMP to me. How about just httpGet(url string)?
|
Thanks @ihcsim ! I have made the changes. :) |
|
This one should be ready to be merged. |
mayankshah1607
force-pushed
the
mayank/ingress-clean
branch
from
03b37ae
to
0abe561
Compare
Signed-off-by: Mayank Shah <mayankshah1614@gmail.com>
Signed-off-by: Mayank Shah <mayankshah1614@gmail.com>
Signed-off-by: Mayank Shah <mayankshah1614@gmail.com>
- Update port-forward to use service - rename `pingIngress` to `httpGet` Signed-off-by: Mayank Shah <mayankshah1614@gmail.com>
Signed-off-by: Mayank Shah <mayankshah1614@gmail.com>
Signed-off-by: Mayank Shah <mayankshah1614@gmail.com>
Signed-off-by: Mayank Shah <mayankshah1614@gmail.com>
Signed-off-by: Mayank Shah <mayankshah1614@gmail.com>
mayankshah1607
force-pushed
the
mayank/ingress-clean
branch
from
723b8f2
to
a2b83f3
Compare
Signed-off-by: Mayank Shah <mayankshah1614@gmail.com>
Pothulapati
approved these changes
Aug 25, 2020
There was a problem hiding this comment.
LGTM! and works well!
{"name":" tap: creating sample application","status":"passed","meta":{"path":"linkerd2-conformance|report.xml|Linkerd2 conformance tests"}}
{"name":" tap: can tap a deployment","status":"passed","meta":{"path":"linkerd2-conformance|report.xml|Linkerd2 conformance tests"}}
{"name":" tap: cannot tap a disabled deployment","status":"passed","meta":{"path":"linkerd2-conformance|report.xml|Linkerd2 conformance tests"}}
{"name":" tap: can tap a service call","status":"passed","meta":{"path":"linkerd2-conformance|report.xml|Linkerd2 conformance tests"}}
{"name":" tap: can tap a pod","status":"passed","meta":{"path":"linkerd2-conformance|report.xml|Linkerd2 conformance tests"}}
{"name":" tap: can filter tap events by method","status":"passed","meta":{"path":"linkerd2-conformance|report.xml|Linkerd2 conformance tests"}}
{"name":" tap: can filter tap events by authority","status":"passed","meta":{"path":"linkerd2-conformance|report.xml|Linkerd2 conformance tests"}}
{"name":" ingress: nginx: should work with Linkerd","status":"passed","meta":{"path":"linkerd2-conformance|report.xml|Linkerd2 conformance tests"}}
{"name":" ingress: nginx: should delete resources created for testing","status":"passed","meta":{"path":"linkerd2-conformance|report.xml|Linkerd2 conformance tests"}}
{"name":" ingress: traefik: should work with Linkerd","status":"passed","meta":{"path":"linkerd2-conformance|report.xml|Linkerd2 conformance tests"}}
{"name":" ingress: traefik: should delete resources created for testing","status":"passed","meta":{"path":"linkerd2-conformance|report.xml|Linkerd2 conformance tests"}}
{"name":" ingress: ambassador: should work with Linkerd","status":"passed","meta":{"path":"linkerd2-conformance|report.xml|Linkerd2 conformance tests"}}
{"name":" ingress: ambassador: should delete resources created for testing","status":"passed","meta":{"path":"linkerd2-conformance|report.xml|Linkerd2 conformance tests"}
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cleaner, refactored version of #12
This PR includes:
I did not directly make changes to #12 so that gloo and contour tests are not lost because of the refactoring process.
Signed-off-by: Mayank Shah mayankshah1614@gmail.com