-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce discovery cache timeout values #10831
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proxy caches results in-memory, both for inbound and outbound service (and policy) discovery. While the proxy's default values are great in most cases, certain client configurations may require overrides. The proxy supports overriding the default values, however, it currently does not offer an easy way for users to configure them. This PR introduces two new values in Linkerd's control plane chart. The values control the inbound and outbound cache discovery idle timeout -- the amount of time a result will be kept in the cache if unused. Setting this value will change the configuration for all injected proxies, but not for the control plane. Signed-off-by: Matei David <matei@buoyant.io>
Signed-off-by: Matei David <matei@buoyant.io>
adleong
reviewed
May 2, 2023
Signed-off-by: Matei David <matei@buoyant.io>
Signed-off-by: Matei David <matei@buoyant.io>
adleong
approved these changes
May 2, 2023
@@ -230,10 +230,12 @@ Kubernetes: `>=1.21.0-0` | |||
| proxy.image.pullPolicy | string | imagePullPolicy | Pull policy for the proxy container Docker image | | |||
| proxy.image.version | string | linkerdVersion | Tag for the proxy container Docker image | | |||
| proxy.inboundConnectTimeout | string | `"100ms"` | Maximum time allowed for the proxy to establish an inbound TCP connection | | |||
| proxy.inboundDiscoveryCacheUnusedTimeout | string | `"90s"` | Maximum time allowed before an unused inbound discovery result is evicted from the cache, defaults to 90s if unspecified | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably don't need to describe the default value in the comment since we can see the default value in the second column now.
Signed-off-by: Matei David <matei@buoyant.io>
alpeb
reviewed
May 4, 2023
alpeb
approved these changes
May 5, 2023
mateiidavid
added a commit
that referenced
this pull request
Jun 1, 2023
The proxy caches results in-memory, both for inbound and outbound service (and policy) discovery. While the proxy's default values are great in most cases, certain client configurations may require overrides. The proxy supports overriding the default values, however, it currently does not offer an easy way for users to configure them. This PR introduces two new values in Linkerd's control plane chart. The values control the inbound and outbound cache discovery idle timeout -- the amount of time a result will be kept in the cache if unused. Setting this value will change the configuration for all injected proxies, but not for the control plane. --------- Signed-off-by: Matei David <matei@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proxy caches results in-memory, both for inbound and outbound service (and policy) discovery. While the proxy's default values are great in most cases, certain client configurations may require overrides. The proxy supports overriding the default values, however, it currently does not offer an easy way for users to configure them.
This PR introduces two new values in Linkerd's control plane chart. The values control the inbound and outbound cache discovery idle timeout -- the amount of time a result will be kept in the cache if unused. Setting this value will change the configuration for all injected proxies, but not for the control plane.
Tests
Overriding options through CLI
Control plane does not receive the overrides:
but injected proxies do
Overriding through Helm
Control plane will not receive overrides: