cni-plugin: v1.1.3 #10855
Merged
cni-plugin: v1.1.3 #10855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This release of the CNI plugin changes the base runtime Docker image from `debian:bullseye-slim` to `scratch. --- * cni: use `scratch` as the base runtime docker image (linkerd/linkerd2-proxy-init#237)
alpeb
reviewed
May 4, 2023
metadata-cni-plugin.json
Outdated
There was a problem hiding this comment.
I think this file was added by mistake
hawkw
added a commit
to linkerd/linkerd2-proxy-init
that referenced
this pull request
May 4, 2023
PR #237 changed the base runtime image for the CNI init container from `debian:bullseye-slim` to `scratch`, in the hopes of reducing the dependency footprint of that image. Unfortunately, it turns out that this breaks the CNI init container, since it must execute shell scripts and therefore requires a shell (specifically, `bash`), which does not exist in the `scratch` image. This was not detected by CI in this repo on PR #237, because it turns out that the CI jobs don't actually try to run the CNI init container. Instead, we didn't discover that this breaks stuff until the change was fully integrated in linkerd/linkerd2#10855. This commit changes the base runtime image again, to `alpine:3.17.3`, similarly to the proxy-init dockerfile. We now install the necessary dependencies using `apk add` in the alpine layer. This way, we should have a shell, and be able to run the install script again.
hawkw
added a commit
to linkerd/linkerd2-proxy-init
that referenced
this pull request
May 4, 2023
PR #237 changed the base runtime image for the CNI init container from `debian:bullseye-slim` to `scratch`, in the hopes of reducing the dependency footprint of that image. Unfortunately, it turns out that this breaks the CNI init container, since it must execute shell scripts and therefore requires a shell (specifically, `bash`), which does not exist in the `scratch` image. This was not detected by CI in this repo on PR #237, because it turns out that the CI jobs don't actually try to run the CNI init container. Instead, we didn't discover that this breaks stuff until the change was fully integrated in linkerd/linkerd2#10855. This commit changes the base runtime image again, to `alpine:3.17.3`, similarly to the proxy-init dockerfile. We now install the necessary dependencies using `apk add` in the alpine layer. We also install `bash`, because Alpine doesn't ship with `bash` by default. This way, we should have a shell, and be able to run the install script again.
adleong
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release of the CNI plugin changes the base runtime Docker image
from
debian:bullseye-slimtoalpine:3.17.3.scratchas the base runtime docker image (cni: usescratchas the base runtime docker image linkerd2-proxy-init#237)scratchtoalpine(linkerd2-proxy-init#238)