Force MeshTLSAuthentication CRs to provide at least one identity/identityRef #10888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tityRef Fixes #10782 Added the `minItems: 1` field to `spec.identities` and `spec.identitiRefs`. This is a BC change so it's not required to bump the CRD version, plus current CRs not abiding to this constraint would be broken anyway. ```bash $ cat << EOF | k apply -f - > apiVersion: policy.linkerd.io/v1alpha1 kind: MeshTLSAuthentication metadata: name: "test" spec: identities: [] > EOF The MeshTLSAuthentication "test" is invalid: spec.identities: Invalid value: 0: spec.identities in body should have at least 1 items ```
…sing items when one of them fails
mateiidavid
approved these changes
May 15, 2023
adleong
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10782
Added the
minItems: 1field tospec.identitiesandspec.identitiRefs. This is a BC change so it's not required to bump the CRD version, plus current CRs not abiding to this constraint would be broken anyway.Also refactored the MeshTLSAuthentication index reset loop to avoid stop processing items when one of them fails.