Configurable tracing service name #12371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @GrigoriyMikhalkin. Thanks for taking the time to submit this and sorry for the delay and getting you a review. I'm curious about a slightly modified approach that might lessen the change required. Specifically, I don't think we should anything about tracing should be part of the linkerd-control-plane chart if we can avoid it. Tell me if you think this could work: jaeger/injector/mutator/patch.go includes tracing-specific proxy configuration, so we should aim to instrument this here. I don't think that we need a new helm value to do this... instead we can use the downward API to reference a dedicated annotation that controls this parameter to set an environment variable. (I'd suggest something like jaeger.linkerd.io/proxy-service-name.) Then, the proxy can use that value as override if it is set and not empty... |
GrigoriyMikhalkin
force-pushed
the
configurable-tracing-service-name
branch
from
1806eff
to
398e29c
Compare
|
Hi @olix0r! I agree that use of downward API allows more elegant solution. Updated the PR. One thing to note is, proxy now relies on annotation named |
GrigoriyMikhalkin
force-pushed
the
configurable-tracing-service-name
branch
from
d13419e
to
eeca7dd
Compare
GrigoriyMikhalkin
force-pushed
the
configurable-tracing-service-name
branch
from
eeca7dd
to
9a9080b
Compare
|
Hi @olix0r! I updated this PR to be up-to-date. |
GrigoriyMikhalkin
force-pushed
the
configurable-tracing-service-name
branch
2 times, most recently
from
aa9a9df
to
3d11a83
Compare
Signed-off-by: GrigoriyMikhalkin <grigoriymikhalkin@gmail.com>
Signed-off-by: GrigoriyMikhalkin <grigoriymikhalkin@gmail.com>
Signed-off-by: GrigoriyMikhalkin <grigoriymikhalkin@gmail.com>
Signed-off-by: GrigoriyMikhalkin <grigoriymikhalkin@gmail.com>
Signed-off-by: GrigoriyMikhalkin <grigoriymikhalkin@gmail.com>
GrigoriyMikhalkin
force-pushed
the
configurable-tracing-service-name
branch
from
3d11a83
to
771d290
Compare
sfleen
added a commit
to sfleen/linkerd2
that referenced
this pull request
Sep 27, 2024
Similar in concept to linkerd#12371, except the configuration lives entirely within the tracing injector config instead of going through the control plane. Fixes linkerd#11157 Signed-off-by: Scott Fleener <scott@buoyant.io>
sfleen
added a commit
to sfleen/linkerd2
that referenced
this pull request
Oct 1, 2024
Similar in concept to linkerd#12371, except the configuration lives entirely within the tracing injector config instead of going through the control plane. Fixes linkerd#11157 Signed-off-by: Scott Fleener <scott@buoyant.io>
sfleen
added a commit
to sfleen/linkerd2
that referenced
this pull request
Oct 2, 2024
Similar in concept to linkerd#12371, except the configuration lives entirely within the tracing injector config instead of going through the control plane. Fixes linkerd#11157 Signed-off-by: Scott Fleener <scott@buoyant.io>
sfleen
added a commit
to sfleen/linkerd2
that referenced
this pull request
Oct 2, 2024
Companion to linkerd/linkerd2-proxy#3245, exposes the configuration for the tracing service name in the proxy to the general linkerd config. Similar in concept to linkerd#12371, except the configuration lives entirely within the tracing injector config instead of going through the control plane. Fixes linkerd#11157 Signed-off-by: Scott Fleener <scott@buoyant.io>
sfleen
added a commit
to sfleen/linkerd2
that referenced
this pull request
Oct 9, 2024
Companion to linkerd/linkerd2-proxy#3245, exposes the configuration for the tracing service name in the proxy to the general linkerd config. Similar in concept to linkerd#12371, except the configuration lives entirely within the tracing injector config instead of going through the control plane. Fixes linkerd#11157 Signed-off-by: Scott Fleener <scott@buoyant.io>
sfleen
added a commit
to sfleen/linkerd2
that referenced
this pull request
Oct 10, 2024
Companion to linkerd/linkerd2-proxy#3245, exposes the configuration for the tracing service name in the proxy to the general linkerd config. Similar in concept to linkerd#12371, except the configuration lives entirely within the tracing injector config instead of going through the control plane. Fixes linkerd#11157 Signed-off-by: Scott Fleener <scott@buoyant.io>
sfleen
added a commit
to sfleen/linkerd2
that referenced
this pull request
Oct 10, 2024
Companion to linkerd/linkerd2-proxy#3245, exposes the configuration for the tracing service name in the proxy to the general linkerd config. Similar in concept to linkerd#12371, except the configuration lives entirely within the tracing injector config instead of going through the control plane. Fixes linkerd#11157 Signed-off-by: Scott Fleener <scott@buoyant.io>
sfleen
added a commit
to sfleen/linkerd2
that referenced
this pull request
Oct 11, 2024
Companion to linkerd/linkerd2-proxy#3245, exposes the configuration for the tracing service name in the proxy to the general linkerd config. Similar in concept to linkerd#12371, except the configuration lives entirely within the tracing injector config instead of going through the control plane. Fixes linkerd#11157 Signed-off-by: Scott Fleener <scott@buoyant.io>
alpeb
pushed a commit
that referenced
this pull request
Oct 11, 2024
Companion to linkerd/linkerd2-proxy#3245, exposes the configuration for the tracing service name in the proxy to the general linkerd config. Similar in concept to #12371, except the configuration lives entirely within the tracing injector config instead of going through the control plane. Fixes #11157 Signed-off-by: Scott Fleener <scott@buoyant.io>
|
This PR can also be closed (see linkerd/linkerd2-proxy#2856). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of solution for #11157
linkerd2-proxy part: linkerd/linkerd2-proxy#2856
Introduces new annotation
config.linkerd.io/tracing-service-namewhich allows to set custom tracing service name for proxy.P.S. Another potential solution would be to use template instead of fixed name, which would allow to set annotation once for namespace, for example. But it has it's own drawback, that in this case we would have to use Pod name or something similar in this template. So, i think the solution with fixed service name annotation is the best.