Move default private connect timeout to Config
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the default value of this setting was in lib.rs instead of being automatically set in `Config` like all the other defaults, which was inconsistent and confusing. Fix this by moving the defaulting logic to `Config`. Validated by running the test suite.
seanmonstar
approved these changes
Dec 14, 2017
hawkw
approved these changes
Dec 14, 2017
dadjeibaah
pushed a commit
that referenced
this pull request
Dec 15, 2017
Previously the default value of this setting was in lib.rs instead of being automatically set in `Config` like all the other defaults, which was inconsistent and confusing. Fix this by moving the defaulting logic to `Config`. Validated by running the test suite.
khappucino
pushed a commit
to Nordstrom/linkerd2
that referenced
this pull request
Mar 5, 2019
Previously the default value of this setting was in lib.rs instead of being automatically set in `Config` like all the other defaults, which was inconsistent and confusing. Fix this by moving the defaulting logic to `Config`. Validated by running the test suite.
khappucino
pushed a commit
to Nordstrom/linkerd2
that referenced
this pull request
Mar 5, 2019
Signed-off-by: Sean McArthur <sean@buoyant.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the default value of this setting was in lib.rs instead of
being automatically set in
Configlike all the other defaults, whichwas inconsistent and confusing.
Fix this by moving the defaulting logic to
Config.Validated by running the test suite.