Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add short to extension check #7076

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Add short to extension check #7076

merged 1 commit into from
Oct 14, 2021

Conversation

sankalp-r
Copy link
Contributor

Fixes #7032

Signed-off-by: Sankalp Rangare sankalprangare786@gmail.com

@sankalp-r sankalp-r requested a review from a team as a code owner October 11, 2021 18:37
adleong
adleong approved these changes Oct 12, 2021
View reviewed changes
Copy link
Member

@adleong adleong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simple fix!

@Pothulapati
Copy link
Contributor

Pothulapati commented Oct 13, 2021 •
edited
Loading

@sankalp-r Thanks for raising the PR. It works well with the viz extension. Can you also do the same for multicluster and jaeger extensions in the same repo? 🤔

@sankalp-r
Add short to extension check
12ac4e8 
Signed-off-by: Sankalp Rangare <sankalprangare786@gmail.com>
@sankalp-r
Copy link
Contributor Author

sankalp-r commented Oct 13, 2021 •
edited
Loading

@sankalp-r Thanks for raising the PR. It works well with the viz extension. Can you also do the same for multicluster and jaeger extensions in the same repo? thinking

I have done the same changes for multicluster and jaeger extensions.
Please have a look.

Pothulapati
Pothulapati approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@Pothulapati Pothulapati merged commit 5647e10 into linkerd:main Oct 14, 2021
adleong pushed a commit that referenced this pull request Oct 22, 2021
@sankalp-r @adleong
Support -oshort flag with extension checks (#7076)
9b677f3 
Fixes #7032

This PR adds the support for `-oshort` flag for the `viz`, `multicluster`
and `jaeger` extensions which used to fail previously with an invalid
error.

Signed-off-by: Sankalp Rangare <sankalprangare786@gmail.com>
@Pothulapati Pothulapati mentioned this pull request Nov 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pothulapati Pothulapati Pothulapati approved these changes

@adleong adleong adleong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

extension checks should support -o short
3 participants
@sankalp-r @Pothulapati @adleong