Improve performance and usability #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change includes major changes identified while implementing linkerd-tcp: - introduce micro-benchmarks so that performance investments may be assessed quantiatively; - update the _multithread_ example to set metrics from multiple threads concurrently; - use atomics for Counter & Gauge, removing locks in update path; - use a fine-grained per-stat mutex to lessen contention in stat update path; - use `&'static str` for all label keys and metric names; - stop using the _twox_ hash, as it does not seem ot have an advantage when applied to our key structure; - make label values implement std::fmt::Display; - add key prefixes (namespaces) to Scope; - export raw histogram buckets to prometheus; - introduce Timer/Timed to support measuring the amount of time it takes for an asynchronous operation to complete; - and update the version to 0.4.0
olix0r
changed the title
olix0r
added a commit
to linkerd/linkerd-tcp
that referenced
this pull request
Jun 10, 2017
linkerd-tcp 0.1.0 constitues a major rewrite. Previously, linkerd-tcp did not properly utilize tokio's task model, which lead to a number of performance and correctness problems. Furthermore, linkerd-tcp's configuration interface was substantially different from linkerd's, which caused some confusion. Now, linkerd-tcp has been redesigned: - to better-leverage tokio's reactor; - to support connection and stream timeouts; - to provide much richer metrics insight; - to be structured like a linkerd-style router; - general correctness improvements. Fixes #26 #40 #49 #50 Depends on linkerd/tacho#20
olix0r
added a commit
to linkerd/linkerd-tcp
that referenced
this pull request
Jun 13, 2017
linkerd-tcp 0.1.0 constitutes a major rewrite. Previously, linkerd-tcp did not properly utilize tokio's task model, which lead to a number of performance and correctness problems. Furthermore, linkerd-tcp's configuration interface was substantially different from linkerd's, which caused some confusion. Now, linkerd-tcp has been redesigned: - to better-leverage tokio's reactor; - to support connection and stream timeouts; - to provide much richer metrics insight; - to be structured like a linkerd-style router; - general correctness improvements. Fixes #26 #40 #49 #50 Depends on linkerd/tacho#20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes major changes identified while implementing linkerd-tcp:
quantiatively;
&'static strfor all label keys and metric names;key structure;
asynchronous operation to complete;