function to return schema elements by id_prefixes #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sierra-moxon
commented
Sep 9, 2021
sierra-moxon
commented
- remove extra refactoring from PR add a convenience method for retrieving model elements by the prefix … #35
cmungall
reviewed
Sep 10, 2021
linkml_runtime/utils/schemaview.py
Outdated
| @@ -529,6 +531,40 @@ def expand_curie(self, uri: str) -> str: | |||
| return ns[pfx] + local_id | |||
| return uri | |||
|
|
|||
| @lru_cache(CACHE_SIZE) | |||
| def get_element_by_prefix( | |||
There was a problem hiding this comment.
perhaps decompose this:
- a method that takes an actual prefix as input and returns element names,
get_elements_applicable_for_prefix - a method that splits CURIEs (or URIs?) and. extracts the prefix
- a wrapper that composes these
get_elements_applicable_for_identifier
There was a problem hiding this comment.
I went ahead and broke this up into 3 methods and added support (by utilizing an existing function! - thanks for the pointer :) ) for URIs as well. Also added a test for URI -- which meant adding monarch_context to the kitchen_sink_no_imports.yaml.
sierra-moxon
changed the title
sierra-moxon
changed the title
cmungall
reviewed
Nov 29, 2021
linkml_runtime/utils/schemaview.py
Outdated
| the id_prefixes mapped to that element. | ||
|
|
||
| """ | ||
| categories = [] |
There was a problem hiding this comment.
minor: categories is a biolinkism - use elements instead? not a big deal as this is not exposed to the caller but still good to use internally consistent variable names
cmungall
reviewed
Nov 29, 2021
linkml_runtime/utils/schemaview.py
Outdated
| """ | ||
| Get a Model element by prefix. | ||
|
|
||
| Parameters |
There was a problem hiding this comment.
minor: can you change to the rst format used for other methods?
cmungall
approved these changes
Nov 29, 2021
|
fixed up doc and moved categories -> elements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.