Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reworked development gulp - Fixes linnovate/mean#1674 #1682

Merged
merged 4 commits into from
Oct 20, 2016
Merged

Reworked development gulp - Fixes linnovate/mean#1674 #1682

merged 4 commits into from
Oct 20, 2016

Conversation

adskjohn
Copy link
Contributor

@adskjohn adskjohn commented Oct 9, 2016 •
edited by jwebbdev
Loading

Reworked development gulp - Fixes #1674, #1690, #1652

@adskjohn
Copy link
Contributor Author

adskjohn commented Oct 9, 2016

@ADSKLowenthal I think this fixes #1674 and I cleaned up the code a little to make it easier to follow the flow.

@timelf123
Copy link
Contributor

LGTM on a preliminary glance, however I have not had time to pull and test

@ADSKLowenthal
Copy link
Contributor

Is Hound-CI complaining about the missing semi-colon at the same time we have some tool/process stripping them?

@liorkesos
Copy link
Member

We will go back to semicolon i assume.
Will discuss tommorow
Lior

On Wed, Oct 12, 2016 at 8:03 PM, ADSKLowenthal notifications@github.com
wrote:

Is Hound-CI complaining about the missing semi-colon at the same time we
have some tool/process stripping them?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1682 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAO9Ix46czHViA9wZ73xmDqQe-O071Rhks5qzRLNgaJpZM4KR4-a
.

Lior Kesos - http://www.linnovate.net
Linnovate - Community Infrastructure Care
mail: lior@linnovate.net
office: +972 722500881
cell: +972 524305252
skype: liorkesos

@jwebbdev jwebbdev mentioned this pull request Oct 13, 2016
Closed
houndci-bot
houndci-bot reviewed Oct 20, 2016
View reviewed changes
tests/e2e/smoke/home.spec.js
browser.get('/')
expect(browser.getTitle()).toMatch(/.*MEAN.*/)
browser.get('/');
expect(browser.getTitle()).toMatch(/.*MEAN.*/);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'browser' is not defined.

houndci-bot
houndci-bot reviewed Oct 20, 2016
View reviewed changes
tests/e2e/smoke/home.spec.js
browser.get('/')
expect(browser.getTitle()).toMatch(/.*MEAN.*/)
browser.get('/');
expect(browser.getTitle()).toMatch(/.*MEAN.*/);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'browser' is not defined.

houndci-bot
houndci-bot reviewed Oct 20, 2016
View reviewed changes
tests/e2e/smoke/home.spec.js
describe('Smoke test home page', function () {
it('title should contain MEAN', function () {
browser.get('/')
expect(browser.getTitle()).toMatch(/.*MEAN.*/)
browser.get('/');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'browser' is not defined.

houndci-bot
houndci-bot reviewed Oct 20, 2016
View reviewed changes
tests/e2e/smoke/home.spec.js
describe('Smoke test home page', function () {
it('title should contain MEAN', function () {
browser.get('/')
expect(browser.getTitle()).toMatch(/.*MEAN.*/)
browser.get('/');
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'browser' is not defined.

ADSKLowenthal
ADSKLowenthal approved these changes Oct 20, 2016
View reviewed changes
gulp/development.js
tasks: function (changedFiles) {
var tasks = [];
changedFiles.forEach(function (file) {
if (path.extname(file) === '.css' && !~tasks.indexOf('csslint')) tasks.push('csslint')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this be a problem if we need to recompile SASS/LESS?

@jwebbdev jwebbdev merged commit 2bf02b9 into linnovate:master Oct 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@ADSKLowenthal ADSKLowenthal ADSKLowenthal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@adskjohn @timelf123 @ADSKLowenthal @liorkesos @houndci-bot @jwebbdev