-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the grunt-contrib-copy package and associated copy task. This task... #412
Conversation
…ask will move the glyphicon fonts, from the default bootstap dist directory, into the public/build/ directory. The bootstrap.min.css file expects the fonts to be in this directory and will cause 404 errors on heroku if they are not present. The copy task has been added the list of tasks run on a heroku production build. If bootstrap is ever served using a CDN, this change should be removed.
Hi Ryan, On Sun, Apr 20, 2014 at 8:22 AM, Ryan Latham notifications@github.comwrote:
Lior Kesos - http://www.linnovate.net |
Hi Lior, No, actually I don't see any practical reason why bootstrap shouldn't be served off a CDN. Doing so increases the speed at which your pages load, decreases load on your own hosting platform, reduces the need to manually manage files (like I had to do in this PR), and I believe is the generally accepted standard for serving static assets. In addition, if the user has already visited a website that used a CDN to deliver the same assets that you are delivering, the browser will use the cached version, completely eliminating the need to redownload them. My only opposition to CDNs is a moral one. The reason most CDNs are free is the CDN hosters record data on anyone that makes a request. Therefore, anyone who visits your website is inadvertently also visiting your CDN's websites. I dislike the lack of transparency. However, I still think using a CDN is a best a practice at this point. I had not mentioned the CDN fix because I saw there was some opposition to in in #291. If you are open to exploring this route though, I would be willing to be remove my changes and test out @udisun's changes to see if they resolved this issue. Ryan |
@ryanlatham @liorkesos any reason we shouldn't merge this PR now to fix the glyphicon problem until we sort out the CDN stuff? |
@fyockm @liorkesos I would think it was a good idea for now. I have been contacted by other users who tried out these changes and have verified they are working. This at least puts you in a functional state until a better solution can be found. |
@ryanlatham what happened to the repo for this PR? |
... will move the glyphicon fonts, from the default bootstrap dist directory, into the public/build/ directory. The bootstrap.min.css file expects the fonts to be in this directory and will cause 404 errors on heroku if they are not present. The copy task has been added the list of tasks run on a heroku production build. If bootstrap is ever served using a CDN, this change should be removed.
Closes #410