Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link_local separator #8

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Fix link_local separator #8

merged 2 commits into from
Nov 14, 2023

Conversation

eljohnson92
Copy link
Contributor

📝 Description

What does this PR do and why is this change necessary?
LinkLocal is returned with an _ not a -

✔️ How to Test

What are the steps to reproduce the issue or verify the changes?

How do I run the relevant unit/integration tests?

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@eljohnson92 eljohnson92 requested a review from a team as a code owner November 14, 2023 02:24
@eljohnson92 eljohnson92 requested review from jriddle-linode and lgarber-akamai and removed request for a team November 14, 2023 02:24
@eljohnson92 eljohnson92 changed the title Fix local_link separator Fix link_local separator Nov 14, 2023
network.go Outdated Show resolved Hide resolved
@zliang-akamai zliang-akamai requested review from a team, ykim-akamai and amisiorek-akamai and removed request for a team November 14, 2023 17:36
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to line up with the API implementation, thanks for the contribution!

@zliang-akamai zliang-akamai merged commit fdd0c80 into linode:main Nov 14, 2023
@zliang-akamai zliang-akamai deleted the patch-1 branch November 14, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants