Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] refactor the utils and common pkgs #212

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

amold1
Copy link
Contributor

@amold1 amold1 commented Aug 27, 2024

General:

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@amold1 amold1 requested review from a team as code owners August 27, 2024 21:54
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 19.04762% with 17 lines in your changes missing coverage. Please review.

Project coverage is 36.94%. Comparing base (b45e75c) to head (444479c).
Report is 3 commits behind head on main.

Files Patch % Lines
internal/driver/controllerserver.go 7.69% 12 Missing ⚠️
internal/driver/nodeserver.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #212   +/-   ##
=======================================
  Coverage   36.94%   36.94%           
=======================================
  Files          23       23           
  Lines        1746     1746           
=======================================
  Hits          645      645           
  Misses       1067     1067           
  Partials       34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@komer3 komer3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amold1 amold1 merged commit c5a07f1 into main Aug 28, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants