Change Func Calls in obj Plug-In to the Newer Functions #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zliang-akamai
requested review from
jriddle-linode,
lgarber-akamai,
ezilber-akamai-zz and
a team
zliang-akamai
changed the title
lgarber-akamai
approved these changes
Feb 14, 2023
jriddle-linode
approved these changes
Feb 14, 2023
zliang-akamai
force-pushed
the
zhiwei/obj-fix
branch
from
d0b3c15
to
6fc0465
Compare
|
Since it was modified after the last review, may I get a re-review? Much appreciated! @lgarber-akamai @jriddle-linode |
lgarber-akamai
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some functions moved to other place during previous refactoring, so, the function calls in obj plug-in also need an adjustment.