Added `get-kubeconfig` plugin #407

ezilber-akamai-zz · 2023-03-20T18:44:35Z

📝 Description

Adds a new linode-cli get-kubeconfig ... command that allows users to merge a kubeconfig from an existing cluster to their local machine.

✔️ How to Test

make tetsunit

Resolves #347

jriddle-linode

Don't forget to link/close the issue.

lgarber-akamai

Nice work! Just a few stylistic/testing improvements

linodecli/plugins/get-kubeconfig.py

tests/unit/test_plugin_kubeconfig.py

lgarber-akamai

Great work! Tests are passing locally; just one optimization to the merge logic and we should be good to go

linodecli/plugins/get-kubeconfig.py

lgarber-akamai

One last change and we should be good to go!

linodecli/plugins/get-kubeconfig.py

lgarber-akamai

Great work! All tests are passing locally and the following commands work as expected on a merged config:

kubectl config get-clusters
kubectl config get-users
kubectl config get-contexts

linodecli/plugins/get-kubeconfig.py

ezilber-akamai added 3 commits March 15, 2023 14:26

Added kubeconfig merge plugin

e9e406d

Added get-kubeconfig plugin and tests

4c4e963

Fixed lint

689958a

ezilber-akamai-zz requested a review from a team March 20, 2023 19:09

jriddle-linode approved these changes Mar 21, 2023

View reviewed changes

ezilber-akamai-zz linked an issue Mar 22, 2023 that may be closed by this pull request

[Feature]: allow to merge kubeconfig of lke cluster using cli without having to do that manually #347

Closed

lgarber-akamai requested changes Mar 22, 2023

View reviewed changes

linodecli/plugins/get-kubeconfig.py Outdated Show resolved Hide resolved

linodecli/plugins/get-kubeconfig.py Outdated Show resolved Hide resolved

tests/unit/test_plugin_kubeconfig.py Outdated Show resolved Hide resolved

lgarber-akamai reviewed Mar 22, 2023

View reviewed changes

tests/unit/test_plugin_kubeconfig.py Show resolved Hide resolved

Improved tests and cleaned up code

d2612d6

lgarber-akamai requested changes Mar 24, 2023

View reviewed changes