migrate unittest to pytest #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykim-akamai
requested review from
jriddle-linode,
zliang-akamai,
yec-akamai and
lgarber-akamai
jriddle-linode
approved these changes
Apr 19, 2023
lgarber-akamai
previously requested changes
Apr 21, 2023
yec-akamai
approved these changes
May 1, 2023
| @@ -41,7 +40,7 @@ def mock_cli( | |||
| # We need this to suppress warnings for operations that don't | |||
| # have access to the cli.suppress_warnings attribute. | |||
| # e.g. operation defaults | |||
| sys.argv.append("--suppress-warnings") | |||
| # sys.argv.append("--suppress-warnings") | |||
There was a problem hiding this comment.
Maybe we can add a bit context on why it needs to be removed here for visibility.
| """ | ||
| Test if the bash completion renders correctly | ||
| """ | ||
| # mocker = mocker.patch('linodecli-completion.get_bash_completions', return_value=self.bash_expected) |
There was a problem hiding this comment.
nit: it seems can be cleaned up.
Changed the file naming instead for consistency. E.g. configuration.py -> test_configuration.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
removed unittest library dependencies in all unit tests
removed unittest command from Makefile
✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
make testunit
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.