new: Adding cross repo testing workflow for Release #378
Conversation
Test/report uploader submodule
# Conflicts: # .github/workflows/e2e-test-pr.yml # .gitmodules
ykim-1
requested review from
jriddle-linode and
yec-akamai
and removed request for
a team
|
Let's use the latest version of each action? For example, checkout@v4 |
ykim-1
requested review from
a team,
lgarber-akamai and
zliang-akamai
and removed request for
a team
| - name: install dependencies | ||
| run: | | ||
| cd .ansible/collections/ansible_collections/linode/cloud | ||
| pip install -r requirements.txt -r requirements-dev.txt --upgrade-strategy only-if-needed |
There was a problem hiding this comment.
Just for some added confidence, would it make sense to install linode_api4 after installing the Ansible Collection deps?
There was a problem hiding this comment.
I verified that the one built is being used in my local environment
╰─➤ pip install linode_api4 --upgrade-strategy only-if-needed
Requirement already satisfied: linode_api4 in ./venv/lib/python3.10/site-packages (0.0.0.dev0)
Requirement already satisfied: requests in ./venv/lib/python3.10/site-packages (from linode_api4) (2.31.0)
I think doing it after might be complicated considering it will be overwritten
| cd .ansible/collections/ansible_collections/linode/cloud | ||
| make testall | ||
| env: | ||
| LINODE_API_TOKEN: ${{ secrets.DX_LINODE_TOKEN }} |
There was a problem hiding this comment.
I think the API token secret for this repo is LINODE_TOKEN rather than DX_LINODE_TOKEN 👍
There was a problem hiding this comment.
Works well on my fork other than the feedback left above: https://github.com/lgarber-akamai/linode_api4-python/actions/runs/8253793207/job/22576579523
Giving this my preemptive approval 🙂
jriddle-linode
added
the
repo-ci-improvement
📝 Description
There is a need to run Ansible integration tests before releasing Linode-py to ensure there are no breaking changes. This PR is a POC for one of the ways to get this done.
The workflow provided in the PR automates testing for Ansible collections on pull request (PR) opening on
mainbranch. Here's a concise overview:Purpose: Automate testing for Ansible collections in SDK repo using the latest code available
Trigger: Runs on PR opening to the main branch or manually triggered.
Job:
✔️ How to Test
https://github.com/ykim-1/linode_api4-python/actions/runs/8241152046/job/22537846853
Tested on a forked repo after opening a PR to main
📷 Preview
If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.