Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a make target, point to upjet fork #43

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Add a make target, point to upjet fork #43

merged 1 commit into from
Jul 26, 2024

Conversation

tchinmai7
Copy link
Collaborator

@tchinmai7 tchinmai7 commented Jul 25, 2024

Description of your changes

  • Add make target to debug the executable in dlv
  • Point to upjet fork that contains fix for nil pointer exception when creating keys
    Reference: crossplane/upjet@67bd255

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

  • Run make local-deploy and make debug
  • Prior to the upjet change, creating a key using the generated key example resulted in an error like:
Reconciler error        {"controller": "managed/objectstorage.linode.upbound.io/v1alpha1, kind=key", "namespace": "", "name": "foo3", "reconcileID": "e25e3b74-91f7-4f9c-aa38-b4bcd6130544", "error": "panic: runtime error: invalid memory address or nil pointer dereference [recovered]"}

causing the resource to never become "Ready"

  • After pointing to the upjet fork, creating a key successfully becomes "Ready" and logs don't show the nil pointer dereference error anymore.

Signed-off-by: Tarun Chinmai Sekar <schinmai@akamai.com>
@sammysclub sammysclub marked this pull request as ready for review July 26, 2024 15:30
@sammysclub sammysclub merged commit e9de81a into main Jul 26, 2024
6 checks passed
@sammysclub
Copy link
Collaborator

sammysclub commented Aug 12, 2024

note - the bugfix was merged to upjet, but hasn't been released yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants