Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes in parsing #82

Closed
ifedchankau opened this issue Jul 30, 2018 · 3 comments · Fixed by #97
Closed

Fixes in parsing #82

ifedchankau opened this issue Jul 30, 2018 · 3 comments · Fixed by #97
Assignees
@ifedchankau
Labels
Type: Bug

Comments

@ifedchankau
Copy link
Collaborator

ifedchankau commented Jul 30, 2018 •
edited
Loading

I've found next errors:

  • when description is fully on next line with option, it is not parsing
  • exception when postfix or names [config] is string (not an array)
  • parseWhole always changing to default config value
@romanrostislavovich
Copy link
Contributor

Name of issue is unclear, please rename it

@ifedchankau
Copy link
Collaborator Author

@svoboda-rabstvo yes, but i still haven't finished with tests. It will be clearer later.

ifedchankau added a commit to ifedchankau/usage-parser that referenced this issue Aug 1, 2018
@ifedchankau
fix: parsing
9ddac5a 
Fixed 3 problems:
- when description is fully on next line with option, it is not parsing
- exception when postfix or names [config] is string (not an array)
- parseWhole always changing to default config value

Closes linterhub#82
@ifedchankau ifedchankau mentioned this issue Aug 1, 2018
Merged
romanrostislavovich pushed a commit that referenced this issue Aug 1, 2018
@ifedchankau @romanrostislavovich
fix: parsing
2741124 
Fixed 3 problems:
- when description is fully on next line with option, it is not parsing
- exception when postfix or names [config] is string (not an array)
- parseWhole always changing to default config value

Closes #82
@romanrostislavovich
Copy link
Contributor

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ifedchankau ifedchankau

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: parsing ifedchankau/usage-parser
2 participants
@romanrostislavovich @ifedchankau