Throw error for invalid rule config #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those validators throw errors for invalid rules config
The `validateConfig` is used to trigger errors when rule's config is not valid. Previously issues were reported for invalid config, which is bad for UX as those issues were lost in the middle of real lint issues. By throwing an error we can stop the linter and tell the user that something is not good.
Call linthtml on an empty string to trigger a check for rules config. If rule config check fail the cli is stopped and the config error is printed.
This is a hack until I find a better solution
delete-merged-branch
bot
deleted the
feat/throw_error_for_invalid_rule_config
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behaviour when a rule's config is not valid is to report an Issue (code E048), this issue will them be listed among lint errors. That behaviour is not good as invalid config are different from lint errors and be lost in the middle.
Wrong configurations should be blocking an invalid configuration should stop the lint process and trigger an error for the user. This is exactly what this PR intent to do.
The PR change the way rules config are handled internally, now an error thrown when an invalid config is found. Same behaviour for inline_config